This repository was archived by the owner on Jun 25, 2026. It is now read-only.
Fix Integration: Recognize clicks from components that use href-to (ember-paper)#43
Closed
openhouse wants to merge 1 commit into
Closed
Conversation
… a route transition on click as long as the element doesn't have an ember action.
Member
|
The ember-href-to package is now maintained by the Ember community and lives at https://github.com/adopted-ember-addons/ember-href-to. We're closing this PR and archiving this repo. If you still think it's relevant, please reopen it against the new repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to use href-to with a component from https://github.com/miguelcobain/ember-paper that renders an anchor element.
{{#paper-button href=(href-to "settings") class="href-to"}}Settings{{/paper-button}}I am able to use the href-to helper to set the
hrefattribute on the component, which renders as expected. Great!But with this, href-to didn't recognize when I clicked the link. I got the hard native browser redirect rather than a nice Ember router transition. It was because every component's element gets the
.ember-viewclass which didn't fit the conditions in href-to's initializer.So I made this pull request to update the initializer. Now href-to recognizes and smoothly transitions clicks on anchor elements when they have the
.href-toclass even if they are components.To stay out of the way, href-to continues to not intervene when there is an action set on an element.